Re: [PATCH 2/2] help: add "man.viewer" config var to use "woman" or "konqueror"

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 18, 2008, 05:08 UTC
Message-ID: <7vodaeua0u.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20080217205252.ff7ea434.chriscool@tuxfamily.org>

Christian Couder <chriscool@tuxfamily.org> writes:

Show 13 quoted lines

>  static void show_man_page(const char *git_cmd)
>  {
>  	const char *page = cmd_to_page(git_cmd);
>  	setup_man_path();
> -	execlp("man", "man", page, NULL);
> +	if (!man_viewer || !strcmp(man_viewer, "man"))
> +		execlp("man", "man", page, NULL);
> +	if (!strcmp(man_viewer, "woman"))
> +		exec_woman_emacs(page);
> +	if (!strcmp(man_viewer, "konqueror"))
> +		exec_man_konqueror(page);
> +	die("'%s': unsupported man viewer.", man_viewer);
>  }

I have to wonder if it makes sense to just define the interface to launch an external user-supplied command, and have that command line determine what actually should happen, e.g. inspect DISPLAY and check emacs version etc.