Re: [PATCH 1/3] Fix error in diff_filepair::status documentation.
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 2, 2008, 06:31 UTC
- Message-ID
- <7vod0y3ahc.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <20081101220314.1116.79924.stgit@gandelf.nowhere.earth>
Yann Dirson <ydirson@altern.org> writes:
Show 16 quoted lines
> Signed-off-by: Yann Dirson <ydirson@altern.org>
> ---
>
> diffcore.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/diffcore.h b/diffcore.h
> index 713cca7..05d0898 100644
> --- a/diffcore.h
> +++ b/diffcore.h
> @@ -62,7 +62,7 @@ struct diff_filepair {
> struct diff_filespec *one;
> struct diff_filespec *two;
> unsigned short int score;
> - char status; /* M C R N D U (see Documentation/diff-format.txt) */
> + char status; /* M C R A D U etc. (see DIFF_STATUS_* in diff.h) */I think you spotted the right bug and fixed it in a wrong way. The status letters are user visible, and "git grep status Documentation/*diff*" mention it in handful places without listing its repertoire, which _is_ the bug.