Re: [PATCH] commit: more compact summary and without extra quotes

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 20, 2009, 03:49 UTC
Message-ID: <7vocy2ocw0.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <adf1fd3d0901191600k6fd7a364h3e55f9600960df03@mail.gmail.com>

Santi Béjar <santi@agolina.net> writes:

Show 12 quoted lines

>>> As discussed in the git mailing list:
>>>
>>> http://marc.info/?l=git&m=122765031208922&w=2
>>>
>>> Signed-off-by: Santi Béjar <santi@agolina.net>
>>> ---
>>
>> You really want to move the link after the ---.  I often read commit
>> messages off-line, and let me tell you: I am not really happy reading
>> links then.  Not at all.
>
> OK, less work for me :-)

I do not mind URL in the commit log; it would help me or other forgetful people three months from now if we need to go back to the original discussion.

I however agree with Dscho that it is irritating when somebody uses URL to avoid summarizing the issue himself. If somebody cares enough and understands the issues discussed at URL to come up with a patch that is worth applying, he surely should be able to summarize the primary idea and issues involved in a few paragraphs.

A summary of discussion in addition to URL would save everybody's time.