Re: [PATCHv4] gitweb: make static files accessible with PATH_INFO
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 28, 2009, 01:07 UTC
- Message-ID
- <7vocxsz19e.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <1233103932-6325-1-git-send-email-giuseppe.bilotta@gmail.com>
Giuseppe Bilotta <giuseppe.bilotta@gmail.com> writes:
Show 24 quoted lines
> When PATH_INFO is defined, static files such as the default CSS or the
> shortcut icon are not accessible beyond the summary page (e.g. in
> shortlog or commit view).
>
> Fix this by adding a <base> tag pointing to the script's own URL.
>
> Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
> ---
> gitweb/gitweb.perl | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index 931db4f..55e3081 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -2901,6 +2901,11 @@ sub git_header_html {
> <meta name="robots" content="index, nofollow"/>
> <title>$title</title>
> EOF
> +# the stylesheet, favicon etc urls won't work correctly with path_info unless we
> +# set the appropriate base URL
> + if ($ENV{'PATH_INFO'}) {
> + print "<base href=\"$my_url\" />\n";
> + }Perhaps this is a stupid question, but is $my_url already safe to include in the output without any further quoting at this point in the codepath?