Re: [PATCH/RFC 4/6] object: add one bit to let creation of private types (OBJ_MAX + n)

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 22, 2009, 18:21 UTC
Message-ID: <7vocwuxrgb.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <e29894ca0902221006u77fdaa89s9cc01fb27bffce0b@mail.gmail.com>

Marc-André Lureau <marcandre.lureau@gmail.com> writes:

Show 15 quoted lines

> ---
>  object.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/object.h b/object.h
> index 89dd0c4..83d3644 100644
> --- a/object.h
> +++ b/object.h
> @@ -21,7 +21,7 @@ struct object_array {
>  	} *objects;
>  };
>
> -#define TYPE_BITS   3
> +#define TYPE_BITS   4
>  #define FLAG_BITS  27

This would increase the value of (TYPE_BITS+FLAG_BITS). We spent a lot of effect to keep sizeof(struct object) to absolute minimum, and you need to have a very good reason if you are breaking it.