git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/7] check_ref_format(): tighten refname rules

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 22, 2009, 23:19 UTC
Message-ID
<7vocvtb0xy.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<alpine.DEB.1.00.0903221539060.10279@pacific.mpi-cbg.de>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 10 quoted lines
> On Sat, 21 Mar 2009, Junio C Hamano wrote:
>
>> Yes, I know that tightening rules retroactively is bad, but this changes 
>> the rules for refnames to forbid:
>
> Tightening rules retroactively is not only bad (if sometimes necessary), 
> but tightening rules without giving the user a chance to recover is really 
> bad.
>
> 'git branch -m' uses check_ref_format() to check the old name.

Because "git branch -d" still allows a malformed funny branch to be removed with this patch, I would say it is Ok as long as release notes clearly says what we are tightening the rule for.

It is very probable that some people may have "master@{24}" in their repositories, but such a branch cannot be accessed with or without this patch anyway, and it is unlikely they created it because they wanted to.

"git branch wtf-dot wtf." followed by "git branch -d wtf." also works; for this one, it might make sense to allow "git branch -m" to rename it, but I do not think it is worth it.

Previous: Johannes Schindelin
Message 14 of 14 in “Clean up interpret_nth_last_branch feature”
  1. 0/7 Clean up interpret_nth_last_branch featureJunio C Hamano, Mar 21, 2009
  2. 1/7 check_ref_format(): tighten refname rulesJunio C Hamano, Mar 21, 2009
  3. 2/7 Rename interpret/substitute nth_last_branch functionsJunio C Hamano, Mar 21, 2009
  4. 3/7 check-ref-format --branch: give Porcelain a way to grok branch shorthandJunio C Hamano, Mar 21, 2009
  5. 4/7 strbuf_branchname(): a wrapper for branch name shorthandsJunio C Hamano, Mar 21, 2009
  6. 5/7 Fix "branch -m @{-1} newname"Junio C Hamano, Mar 21, 2009
  7. 6/7 strbuf_check_branch_ref(): a helper to check a refname for a branchJunio C Hamano, Mar 21, 2009
  8. 7/7 checkout -: make "-" to mean "previous branch" everywhereJunio C Hamano, Mar 21, 2009
  9. 7/7 checkout -: make "-" to mean "previous branch" everywhereJunio C Hamano, Mar 22, 2009
  10. Bert WesargMar 22, 2009
  11. Junio C HamanoMar 22, 2009
  12. Junio C HamanoMar 21, 2009
  13. Johannes SchindelinMar 22, 2009
  14. Junio C HamanoMar 22, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.