Re: [PATCH] Fix "unpack-objects --strict"
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 14, 2009, 07:31 UTC
- Message-ID
- <7vocqisvfk.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <20090814071949.GA2342@auto.tuwien.ac.at>
Martin Koegler <mkoegler@auto.tuwien.ac.at> writes:
Show 5 quoted lines
> I'm talking on the server side of a push operation (receive-pack), not > the client side. The patchset should prevent invalid data from > entering the repository, thereby preventing upload-pack (during further > fetch operation) and other git programs (eg. called from gitweb) from > failing/segfaulting.
upload-pack won't feed starting from a random object for a reason, so your worry is unfounded.
I'd agree gitweb may be a problem. Ideally it should restrict itself from anything reachable from the refs of he repository---patches welcome.