Re: install does not obey DESTDIR or --prefix for perl modules
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 21, 2009, 19:44 UTC
- Message-ID
- <7vocp4ulq2.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <20090921191943.GE8173@gryning.com>
Craig Taylor <c@gryning.com> writes:
> Exactly as you describe here, different paths but same goal. > All binaries follow the DESTDIR path except the perl modules. > > To register this as a bug do I need to do more than send this email?
Do you use NO_PERL_MAKEMAKER in your build?
If not, we need to summon an expert on ExtUtils::MakeMaker to look into this issue, but if you do, perhaps you can try this patch and report how well it works for you.
--- perl/Makefile | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/perl/Makefile b/perl/Makefile index e3dd1a5..4ab21d6 100644 --- a/perl/Makefile +++ b/perl/Makefile @@ -29,11 +29,11 @@ $(makfile): ../GIT-CFLAGS Makefile '$(PERL_PATH_SQ)' -MError -e 'exit($$Error::VERSION < 0.15009)' || \ echo ' cp private-Error.pm blib/lib/Error.pm' >> $@ echo install: >> $@ - echo ' mkdir -p "$(instdir_SQ)"' >> $@ - echo ' $(RM) "$(instdir_SQ)/Git.pm"; cp Git.pm "$(instdir_SQ)"' >> $@ - echo ' $(RM) "$(instdir_SQ)/Error.pm"' >> $@ + echo ' mkdir -p "$$(DESTDIR)$(instdir_SQ)"' >> $@ + echo ' $(RM) "$$(DESTDIR)$(instdir_SQ)/Git.pm"; cp Git.pm "$$(DESTDIR)$(instdir_SQ)"' >> $@ + echo ' $(RM) "$$(DESTDIR)$(instdir_SQ)/Error.pm"' >> $@ '$(PERL_PATH_SQ)' -MError -e 'exit($$Error::VERSION < 0.15009)' || \ - echo ' cp private-Error.pm "$(instdir_SQ)/Error.pm"' >> $@ + echo ' cp private-Error.pm "$$(DESTDIR)$(instdir_SQ)/Error.pm"' >> $@ echo instlibdir: >> $@ echo ' echo $(instdir_SQ)' >> $@ else