Re: [PATCH v3] git-gui: adjust the minimum height of diff pane for shorter screen height

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 15, 2009, 19:57 UTC
Message-ID: <7voco84ehu.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1255583127-14893-1-git-send-email-vietor@vxwo.org>

Vietor Liu <vietor@vxwo.org> writes:

> When the screen height is shorter (e.g. Netbook screen 1024x600), both the
> partial commit pane and the status bar will hide. This patch adjust the
> minimum height of the diff pane, allowing the overall window to be shorter
> and still display both the entire commit pane and status bar.

Ah, I finally can parse and understand what this s/15/5/ change was about ;-). Perhaps with "s/will hide/are hidden/" it would be perfect?

Show 26 quoted lines

>
> Signed-off-by: Vietor Liu <vietor@vxwo.org>
> ---
>  git-gui.sh |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/git-gui.sh b/git-gui.sh
> index 09b2720..037a1f2 100755
> --- a/git-gui.sh
> +++ b/git-gui.sh
> @@ -3083,7 +3083,7 @@ frame .vpane.lower.diff.body
>  set ui_diff .vpane.lower.diff.body.t
>  text $ui_diff -background white -foreground black \
>  	-borderwidth 0 \
> -	-width 80 -height 15 -wrap none \
> +	-width 80 -height 5 -wrap none \
>  	-font font_diff \
>  	-xscrollcommand {.vpane.lower.diff.body.sbx set} \
>  	-yscrollcommand {.vpane.lower.diff.body.sby set} \
> -- 
> 1.6.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html