Re: make install error

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 28, 2010, 08:56 UTC
Message-ID: <7vockemwu3.fsf@alter.siamese.dyndns.org>
In-Reply-To: <81b0412b1001280048y6f91ad25t5c636f959630825@mail.gmail.com>

Alex Riesen <raa.lkml@gmail.com> writes:

Show 13 quoted lines

> On Thu, Jan 28, 2010 at 03:53, Junio C Hamano <gitster@pobox.com> wrote:
>> kap4lin <kap4lin@gmail.com> writes:
>>
>>> (cd blt && gtar cf - .) | \
>>>         (cd '/scratch/kap4lin/usr/share/git-core/templates' && umask
>>> 022 && gtar xof -)
>>> gtar: This does not look like a tar archive
>>
>> Perhaps "unset CDPATH".
>>
>
> BTW, will "cd ./blt &>/dev/null" also help and prevent this problem from
> happening ever again?

Except that (1) it would be ">/dev/null", and (2) why contaminate Makefile command lines with such unreadability to work around stupid misdesign of CDPATH?

I _could_ live with something like this that won't affect the main part of the Makefile, though.

 Makefile |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/Makefile b/Makefile
index af08c8f..20b0b34 100644
--- a/Makefile
+++ b/Makefile
@@ -1,6 +1,10 @@
 # The default target of this Makefile is...
 all::
 
+# Work around CDPATH exported to the environment that would
+# break "(cd there && tar cf - ) | tar xf -" and the like.
+CDPATH :=
+
 # Define V=1 to have a more verbose compile.
 #
 # Define SHELL_PATH to a POSIX shell if your /bin/sh is broken.