git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/4] git-mailsplit: add `mailsplit.keepcr` configuration variable.

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 12, 2010, 22:00 UTC
Message-ID
<7vocjum7wp.fsf@alter.siamese.dyndns.org>
In-Reply-To
<7vr5oqnmzr.fsf@alter.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> writes:
Show 13 quoted lines
> "Stefan-W. Hahn" <stefan.hahn@s-hahn.de> writes:
>
>> But perhaps it will be a better aproach to make such a configuration
>> available for git-am. I will make a patch for this soon.
>
> If a configuration is desired, I think that is probably a saner place to
> put it.
>
> Regardless of where the configuration goes between am and mailsplit, you
> need to think about the interaction between rebase and am.  You might set
> the configuration for am---should that automatically and always kick in
> when you run rebase?  Do we need some way to override it per invocation
> when running rebase?

Nah, I wasn't thinking straight. There is no reason to turn it off while rebase is running. That means under --rebasing mode, am should ignore the configuration and always do keep-cr, even when am.keepcr is set to false.

Sorry about the noise.
Previous: Junio C HamanoNext: Stefan-W. Hahn
Message 7 of 13 in “[PATCHv2 0/4] Using git-mailsplit in mixed line ending environment”
  1. Stefan-W. HahnFeb 11, 2010
  2. 1/4 git-mailsplit: Show parameter '--keep-cr' in usage and documentationStefan-W. Hahn, Feb 11, 2010
  3. 2/4 git-mailsplit: add `mailsplit.keepcr` configuration variable.Stefan-W. Hahn, Feb 11, 2010
  4. Junio C HamanoFeb 11, 2010
  5. Stefan-W. HahnFeb 12, 2010
  6. Junio C HamanoFeb 12, 2010
  7. Junio C HamanoFeb 12, 2010
  8. Stefan-W. HahnFeb 12, 2010
  9. 3/4 git-am: Add command line parameter `--keep-cr` passing it to git-mailsplit.Stefan-W. Hahn, Feb 11, 2010
  10. Junio C HamanoFeb 11, 2010
  11. Stefan-W. HahnFeb 12, 2010
  12. Junio C HamanoFeb 12, 2010
  13. 4/4 Adding test for `--keep-cr` for git-mailsplit and git-am.Stefan-W. Hahn, Feb 11, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.