Re: [PATCH 2/4] git-mailsplit: add `mailsplit.keepcr` configuration variable.
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 12, 2010, 22:00 UTC
- Message-ID
- <7vocjum7wp.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <7vr5oqnmzr.fsf@alter.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> writes:
Show 13 quoted lines
> "Stefan-W. Hahn" <stefan.hahn@s-hahn.de> writes: > >> But perhaps it will be a better aproach to make such a configuration >> available for git-am. I will make a patch for this soon. > > If a configuration is desired, I think that is probably a saner place to > put it. > > Regardless of where the configuration goes between am and mailsplit, you > need to think about the interaction between rebase and am. You might set > the configuration for am---should that automatically and always kick in > when you run rebase? Do we need some way to override it per invocation > when running rebase?
Nah, I wasn't thinking straight. There is no reason to turn it off while rebase is running. That means under --rebasing mode, am should ignore the configuration and always do keep-cr, even when am.keepcr is set to false.
Sorry about the noise.