git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] remote-helpers: build in platform independent directory

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 17, 2010, 18:41 UTC
Message-ID
<7vocbw2oxt.fsf@alter.siamese.dyndns.org>
In-Reply-To
<36e03068ded278b5145fdf82658c3270a25c2762.1284740217.git.git@drmicha.warpmail.net>
Michael J Gruber <git@drmicha.warpmail.net> writes:
Show 25 quoted lines
> The build directory which is used by distutils depends on the platform
> (e.g. build/lib on Fedora 13, build/lib.linux-i686-2.6 on Ubuntu 9.04).
> But test-lib.sh expects to find the build in build/lib which can cause
> t5800-remote-helpers.sh to fail early.
>
> Override distutils' choice so that the build is always in build/lib.
>
> Signed-off-by: Michael J Gruber <git@drmicha.warpmail.net>
> ---
>  git_remote_helpers/Makefile |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/git_remote_helpers/Makefile b/git_remote_helpers/Makefile
> index 74b05dc..e8172d3 100644
> --- a/git_remote_helpers/Makefile
> +++ b/git_remote_helpers/Makefile
> @@ -26,7 +26,7 @@ PYLIBDIR=$(shell $(PYTHON_PATH) -c \
>  	 print 'lib/python%i.%i/site-packages' % sys.version_info[:2]")
>  
>  all: $(pysetupfile)
> -	$(QUIET)$(PYTHON_PATH) $(pysetupfile) $(QUIETSETUP) build
> +	$(QUIET)$(PYTHON_PATH) $(pysetupfile) $(QUIETSETUP) build --build-purelib=build/lib --build-platlib=build/lib
>  
>  install: $(pysetupfile)
>  	$(PYTHON_PATH) $(pysetupfile) install --prefix $(DESTDIR_SQ)$(prefix)

Hmm, wouldn't this interfere with the install target if you do not tell the "setup.py install" where your built stuff lives?

Previous: Sverre Rabbelier
Message 3 of 3 in “remote-helpers: build in platform independent directory”
  1. remote-helpers: build in platform independent directoryMichael J Gruber, Sep 17, 2010
  2. Sverre RabbelierSep 17, 2010
  3. Junio C HamanoSep 17, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.