git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 13/16] send-email: extract_valid_address use qr// regexes and /o

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 30, 2010, 17:25 UTC
Message-ID
<7vocbfjg7x.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20100930161912.GA8707@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 5 quoted lines
> ...
> But we are unnecessarily compiling the sub-regexes each time. Not that
> this is probably a performance critical piece of code, but your "/o" is
> doing very little, and this is exactly the sort perl wankery that I find
> interesting.

Well, isn't the _sole_ point of using qr// to optimize by avoiding recompilation? If this is not a performance critical section of the code, what is the point of this change?

This [PATCH 13/16] and also [PATCH 12/16] rewrite strings using qr// but the patterns thus compiled are used exactly once before the control leaves the scope of the variables, so...

It is a different story if the patch instead introduced module-level global variables to hold a pre-compiled regexp objects, but that is not what we are seeing here.

Previous: Jeff KingNext: Ævar Arnfjörð Bjarmason
Message 18 of 29 in “git-send-email cleanups”
  1. 00/16 git-send-email cleanupsÆvar Arnfjörð Bjarmason, Sep 30, 2010
  2. 01/16 send-email: use lexical filehandle for opendirÆvar Arnfjörð Bjarmason, Sep 30, 2010
  3. 02/16 send-email: use lexical filehandles for $composeÆvar Arnfjörð Bjarmason, Sep 30, 2010
  4. 03/16 send-email: use lexical filehandles during sendingÆvar Arnfjörð Bjarmason, Sep 30, 2010
  5. 04/16 send-email: get_patch_subject doesn't need a prototypeÆvar Arnfjörð Bjarmason, Sep 30, 2010
  6. 05/16 send-email: file_declares_8bit_cte doesn't need a prototypeÆvar Arnfjörð Bjarmason, Sep 30, 2010
  7. 06/16 send-email: unique_email_list doesn't need a prototypeÆvar Arnfjörð Bjarmason, Sep 30, 2010
  8. 07/16 send-email: cleanup_compose_files doesn't need a prototypeÆvar Arnfjörð Bjarmason, Sep 30, 2010
  9. 08/16 send-email: use \E***\Q instead of \*\*\*Ævar Arnfjörð Bjarmason, Sep 30, 2010
  10. 09/16 send-email: sanitize_address use $foo, not "$foo"Ævar Arnfjörð Bjarmason, Sep 30, 2010
  11. 10/16 send-email: sanitize_address use qq["foo"], not "\"foo\""Ævar Arnfjörð Bjarmason, Sep 30, 2010
  12. 11/16 send-email: use (?:) instead of () if no match variables are neededÆvar Arnfjörð Bjarmason, Sep 30, 2010
  13. 12/16 send-email: is_rfc2047_quoted use qr// regexesÆvar Arnfjörð Bjarmason, Sep 30, 2010
  14. 13/16 send-email: extract_valid_address use qr// regexes and /oÆvar Arnfjörð Bjarmason, Sep 30, 2010
  15. Jeff KingSep 30, 2010
  16. Ævar Arnfjörð BjarmasonSep 30, 2010
  17. Jeff KingOct 1, 2010
  18. Junio C HamanoSep 30, 2010
  19. Ævar Arnfjörð BjarmasonSep 30, 2010
  20. 13/16 send-email: extract_valid_address use qr// regexesÆvar Arnfjörð Bjarmason, Sep 30, 2010
  21. 14/16 send-email: send_message die on $!, not $?Ævar Arnfjörð Bjarmason, Sep 30, 2010
  22. 15/16 send-email: make_message_id use "require" instead of "use"Ævar Arnfjörð Bjarmason, Sep 30, 2010
  23. 16/16 send-email: use Perl idioms in while loopÆvar Arnfjörð Bjarmason, Sep 30, 2010
  24. Brian GernhardtSep 30, 2010
  25. Jeff KingSep 30, 2010
  26. Brian GernhardtSep 30, 2010
  27. Ævar Arnfjörð BjarmasonSep 30, 2010
  28. Jay SoffianSep 30, 2010
  29. Jeff KingSep 30, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.