Re: [PATCH 1/2] diff: introduce --stat-lines to limit the stat lines
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 29, 2011, 16:15 UTC
- Message-ID
- <7voc3pyqy4.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <5f16db0f3730be70ff522e63fbd491dc910c34d0.1304089050.git.git@drmicha.warpmail.net>
Michael J Gruber <git@drmicha.warpmail.net> writes:
Show 6 quoted lines
> I would even consider a default of 10 (i.e. show a 20 line stat in full, > abbreviate larger ones) to be sensible but have refrained from such a > behaviour change. > > We have hardcoded defaults for width (80) and name-width (50), so having > one for lines should be okay also. Can I has tis wiz default? ;)
The terminal has fixed width to be apportioned but has an infinite height with scrolling, so that comparison is somewhat bogus.
This should be called "count", not "lines". Anticipate a future where we introduce a variant of --stat (in a way similar to how --numstat is a variant of --stat) that displays its result with two lines per entry.
Also getting (N+1) "lines" output for specifying N feels very unnatural.