git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/3] show_ref(): remove unused "flag" and "cb_data" arguments

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 7, 2012, 05:08 UTC
Message-ID
<7vobuggkvs.fsf@alter.siamese.dyndns.org>
In-Reply-To
<1325859153-31016-3-git-send-email-mhagger@alum.mit.edu>
mhagger@alum.mit.edu writes:
> I suppose, though I didn't verify, that the old function signature was
> a vestige of its earlier having been used as a callback function.  But
> it doesn't really matter; the point is that the extra arguments are
> currently not needed.

Yeah, since 8a65ff7 (Generalize the "show each ref" code in receice-pack, 2005-07-02) the function has always been fed to for_each_ref(), but when 6b01ecf (ref namespaces: Support remote repositories via upload-pack and receive-pack, 2011-07-08) introduced show_ref_cb() as the callback that uses show_ref() as a helper, it forgot to do the clean-up in this patch.

Previous: mhagger@alum.mit.eduNext: mhagger@alum.mit.edu
Message 4 of 7 in “Eliminate one user of extra_refs”
  1. 0/3 Eliminate one user of extra_refsmhagger@alum.mit.edu, Jan 6, 2012
  2. 1/3 receive-pack: move more work into write_head_info()mhagger@alum.mit.edu, Jan 6, 2012
  3. 2/3 show_ref(): remove unused "flag" and "cb_data" argumentsmhagger@alum.mit.edu, Jan 6, 2012
  4. Junio C HamanoJan 7, 2012
  5. 3/3 write_head_info(): handle "extra refs" locallymhagger@alum.mit.edu, Jan 6, 2012
  6. Junio C HamanoJan 6, 2012
  7. Jeff KingJan 6, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.