git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Document the --done option.

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 22, 2012, 17:38 UTC
Message-ID
<7vobm2968x.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20120822105705.GA30472@thyrsus.com>
"Eric S. Raymond" <esr@thyrsus.com> writes:
> ---
A forgotten Sign-off?

Sverre, the text matches my understanding as well as what be56862 (fast-import: introduce 'done' command, 2011-07-16) says it did. Ack?

Show 31 quoted lines
>  Documentation/git-fast-import.txt |    8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/git-fast-import.txt b/Documentation/git-fast-import.txt
> index 2620d28..9291ea0 100644
> --- a/Documentation/git-fast-import.txt
> +++ b/Documentation/git-fast-import.txt
> @@ -39,6 +39,10 @@ OPTIONS
>  	See ``Date Formats'' below for details about which formats
>  	are supported, and their syntax.
>  
> +-- done::
> +	Terminate with error if there is no 'done' command at the 
> +	end of the stream.
> +
>  --force::
>  	Force updating modified existing branches, even if doing
>  	so would cause commits to be lost (as the new commit does
> @@ -1047,7 +1051,9 @@ done::
>  	Error out if the stream ends without a 'done' command.
>  	Without this feature, errors causing the frontend to end
>  	abruptly at a convenient point in the stream can go
> -	undetected.
> +	undetected.  This may occur, for example, if an import
> +	front end dies in mid-operation without emitting SIGTERM
> +	or SIGKILL at its subordinate git fast-import instance.
>  
>  `option`
>  ~~~~~~~~
> -- 
> 1.7.9.5
Previous: Eric S. RaymondNext: Sverre Rabbelier
Message 2 of 5 in “Document the --done option.”
  1. Document the --done option.Eric S. Raymond, Aug 22, 2012
  2. Junio C HamanoAug 22, 2012
  3. Sverre RabbelierAug 22, 2012
  4. Junio C HamanoAug 24, 2012
  5. Junio C HamanoSep 12, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.