Re: [PATCH 1/1] tests: Allow customization of how say_color() prints

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 16, 2012, 06:34 UTC
Message-ID: <7vobhuqzdc.fsf@alter.siamese.dyndns.org>
In-Reply-To: <50CCCB86.5080701@ramsay1.demon.co.uk>

Ramsay Jones <ramsay@ramsay1.demon.co.uk> writes:

Show 37 quoted lines

> diff --git a/t/test-lib.sh b/t/test-lib.sh
> index f50f834..9dcf3c1 100644
> --- a/t/test-lib.sh
> +++ b/t/test-lib.sh
> @@ -202,6 +202,15 @@ do
>  	esac
>  done
>  
> +if test -z "$GIT_TEST_PRINT"
> +then
> +	GIT_TEST_PRINT="printf %s"
> +fi
> +if test -z "$GIT_TEST_PRINT_LN"
> +then
> +	GIT_TEST_PRINT_LN="printf %s\n"
> +fi
> +
>  if test -n "$color"
>  then
>  	say_color () {
> @@ -221,7 +230,7 @@ then
>  			test -n "$quiet" && return;;
>  		esac
>  		shift
> -		printf "%s" "$*"
> +		$GIT_TEST_PRINT "$*"
>  		tput sgr0
>  		echo
>  		)
> @@ -230,7 +239,7 @@ else
>  	say_color() {
>  		test -z "$1" && test -n "$quiet" && return
>  		shift
> -		printf "%s\n" "$*"
> +		$GIT_TEST_PRINT_LN "$*"
>  	}
>  fi

As you said, this is ugly and also unwieldy in that I do not see an easy way for a platform/builder to define something that needs to pass a parameter with $IFS in it in these two variables.

Why does your printf die in the first place???