Re: [PATCH] remote-hg: store converted URL
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 15, 2013, 20:10 UTC
- Message-ID
- <7vobgq2ono.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <B35B3EA6-F01B-46D8-AC3D-0F7C8A45A06B@quendi.de>
Max Horn <max@quendi.de> writes:
Show 6 quoted lines
> So far, all I look at do not deal with this at all. Any attempts > to deal with it should be pretty easy to recognize: The > remote-$backend would have to store something into the git config, > or else, verify the opaque token and refuse to work with it under > certain conditions (e.g. when it contains a relative path). But > they don't. E.g. git-remote-testgit has the exact same problem.
Thanks for confirming what I suspected. I think the way Felipe's patch makes remote-hg take responsibility of how $opaqueToken should look like for future invocations is the simplest and makes the most sense. We could try to go fancier and end up over-engineering, but I'd rather have a simple fix in the tree first.
Thanks.