git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 2/2] mergetools: Simplify how we handle "vim" and "defaults"

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 27, 2013, 03:15 UTC
Message-ID
<7vobgbz58a.fsf@alter.siamese.dyndns.org>
In-Reply-To
<1359247573-75825-1-git-send-email-davvid@gmail.com>
David Aguilar <davvid@gmail.com> writes:
Show 12 quoted lines
> @@ -44,19 +46,9 @@ valid_tool () {
>  }
>  
>  setup_tool () {
> -	case "$1" in
> -	vim*|gvim*)
> -		tool=vim
> -		;;
> -	*)
> -		tool="$1"
> -		;;
> -	esac

This part was an eyesore every time I looked at mergetools scripts. Good riddance.

Is there still other special case like this, or was this the last one?

Thanks, both of you, for working on this.
Previous: David AguilarNext: David Aguilar
Message 2 of 4 in “mergetools: Simplify how we handle "vim" and "defaults"”
  1. 2/2 mergetools: Simplify how we handle "vim" and "defaults"David Aguilar, Jan 27, 2013
  2. Junio C HamanoJan 27, 2013
  3. David AguilarJan 27, 2013
  4. Junio C HamanoJan 27, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.