Re: [PATCH 01/19] spell checking

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 9, 2013, 19:45 UTC
Message-ID: <7vobese4rp.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CALeLG_=R4o1y-kA+n883nnAu+jrjgaA2ys2d+Vo9KasmVKeduQ@mail.gmail.com>

Paul Campbell <pcampbell@kemitix.net> writes:

Show 8 quoted lines

> From 72fc84b6e5085b328cc90e664c9f85a1f5cde36c Mon Sep 17 00:00:00 2001
> From: Paul Cartwright <paul.cartwright@ziilabs.com>
> Date: Thu, 27 Jan 2011 22:33:06 +0800
> Subject: [PATCH 01/19] spell checking
>
> ---
>  contrib/subtree/git-subtree.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

I won't repeat these for other 18 patches, but please:

 - drop the first "From <object name> <magic timestamp>" line which
   is not part of the patch (it is only meant to help people who
   maintain the "file(1)" and "magic(5)");

 - keep "From: <author name> ..." and "Date: " lines for other
   peoples' patches you are forwarding (they can be dropped for your
   own patches); and

 - drop "Subject: " as that is the same as the subject of the e-mail
   message.

 - fix the subject to make it clear that the change is for
   contrib/subtree.

   "spell checking" [*1*] in the output of "git shortlog v1.8.1..",
   together with other 600+ patches' titles, will not help the
   reader to see how much activity each area had and who worked in
   what area.

 - have the authors sign-off their patches, and then add yours as
   the person who is forwarding other peoples' patches (see
   Documentation/SubmittingPatches).

 - Cc the area maintainer (I thought it was David Greene?)

if these patches are meant to become part of git.git eventually.

Thanks.

[Footnote]

*1* Besides, a patch can never be "spell *checking*".  It would be
 "typofix" after the author did a 'spell checking' ;-)