Re: [PATCH] t4202 (log): add failing test for log with subtree

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 23, 2013, 16:03 UTC
Message-ID: <7vobd5jktd.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CALkWK0noVfRoXAH75r4yBijXSHD5yusLcKgGC=8bjOW6=qCMng@mail.gmail.com>

Ramkumar Ramachandra <artagnon@gmail.com> writes:

Show 7 quoted lines

> Further, this can speed up tree-rename detection greatly (in fact, I'm
> thinking the first implementation will depend on this information
> being present).  I inspect M^{tree} and I want to know how it's
> composed from M^1^{tree} and M^2^{tree}.  Simple.  In M^{tree}, look
> for trees that have this additional data filled in: then we can just
> short-circuit the rename detection to matching the similarity of this
> tree with M^1^{tree} and M^2^{tree}.

If you need the history context (i.e. M, M^1, M^2) around it to interpret that additional information, isn't it essentially the same as storing renames in the merge commit M?

Not very impressed, at least not yet.