Re: [RFC] GIT paths

From: Junio C Hamano <junkio@cox.net>
Date: Oct 26, 2005, 06:12 UTC
Message-ID: <7vmzkwajrv.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <435E259D.3040701@op5.se>

Andreas Ericsson <ae@op5.se> writes:

Show 7 quoted lines

> About the literally named /~junio directory, it would be possible with 
> this syntax;
>
> 	git fetch host.xz:/~junio
>
> The userdir is (with my previous patch) only expanded if the path starts 
> with a tilde.

I do not necessarily consider that a feature; see next item.

Show 6 quoted lines

> It must remove the leading slash for this syntax:
>
> 	ssh://host.xz/~junio/repo
>
> Otherwise it would be passed as /~junio/repo to the remote end and no 
> ~user interpolation would be done.

Not necessarily. Having the remote end interpret "/~user" and "~user" the same way might make things more consistent; in other words, "http://host/~user" is not spelled "http://host~user".

> I'd say make it invoke the programs with the canonicalized path. As you 
> say, git-daemon has to verify that it's a proper git repo and in the 
> whitelist anyway so I think it would be silly to add extra complexity to 
> upload-pack and receive-pack.

Yeah, I tend to agree here.

>>  - Give --server-root=/path/to/root flag to programs...
>
> If we stick with canonicalized paths I suppose this can be dropped.

Sounds good.