git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Move couple of ifdefs after "include config.mk"

From
Junio C Hamano <junkio@cox.net>
Date
Dec 1, 2005, 09:04 UTC
Message-ID
<7vmzjlkx2f.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<Pine.LNX.4.63.0512010906400.22709@wbgn013.biozentrum.uni-wuerzburg.de>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> But it is only one line, heck only 20 bytes!

Hey, don't get so piped up. Timo's patch has already been merged (thanks, Timo).

But think about it a bit.

If you need an override, you have to write down and maintain those YesPlease _somewhere_ yourself anyway, outside what I ship. Either "config.mak" or "Make" script.

If we have '-include' in the Makefile, we need to make a decision if what we are adding to the Makefile should be overridable by that config.mak every time, exactly because whatever is included becomes part of the Makefile. IOW, that "only 20 bytes" adds work for the Makefile maintainer.

"Make" script method is a command line override to the "make" program, which takes precedence and does not have that problem.

Previous: Johannes SchindelinNext: Alex Riesen
Message 6 of 12 in “Move "-include config.mak" to end of configuration section”
  1. Move "-include config.mak" to end of configuration sectionTimo Hirvonen, Nov 30, 2005
  2. Johannes SchindelinDec 1, 2005
  3. Move couple of ifdefs after "include config.mk"Timo Hirvonen, Dec 1, 2005
  4. Junio C HamanoDec 1, 2005
  5. Johannes SchindelinDec 1, 2005
  6. Junio C HamanoDec 1, 2005
  7. Alex RiesenDec 1, 2005
  8. Junio C HamanoDec 1, 2005
  9. Alex RiesenDec 1, 2005
  10. Junio C HamanoDec 1, 2005
  11. Alex RiesenDec 1, 2005
  12. Johannes SchindelinDec 3, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.