Re: [PATCH] Move couple of ifdefs after "include config.mk"
- From
Junio C Hamano <junkio@cox.net>
- Date
- Dec 1, 2005, 09:04 UTC
- Message-ID
- <7vmzjlkx2f.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <Pine.LNX.4.63.0512010906400.22709@wbgn013.biozentrum.uni-wuerzburg.de>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> But it is only one line, heck only 20 bytes!
Hey, don't get so piped up. Timo's patch has already been merged (thanks, Timo).
But think about it a bit.
If you need an override, you have to write down and maintain those YesPlease _somewhere_ yourself anyway, outside what I ship. Either "config.mak" or "Make" script.
If we have '-include' in the Makefile, we need to make a decision if what we are adding to the Makefile should be overridable by that config.mak every time, exactly because whatever is included becomes part of the Makefile. IOW, that "only 20 bytes" adds work for the Makefile maintainer.
"Make" script method is a command line override to the "make" program, which takes precedence and does not have that problem.