Re: git-clone --reference problem?

From: Junio C Hamano <junkio@cox.net>
Date: Apr 24, 2006, 08:12 UTC
Message-ID: <7vmzeb8k9l.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <Pine.LNX.4.64.0604231122490.3701@g5.osdl.org>

Linus Torvalds <torvalds@osdl.org> writes:

Show 11 quoted lines

> Maybe something like this could work.
>
> Untested, of course. It probably isn't even syntactically correct shell. 
> Whatever. You get the idea.
>
> (That while-loop could probably be simplified to just a 
>
>   cat ""$reference/objects/info/alternates" >> "$GIT_DIR/objects/info/alternates"
>
> because all alternates _should_ already be absolute paths, but hey, 
> whatever.

I was hoping that the solution would be to do the recursive alternate resolution on the runtime side (IOW, prepare_alt_odb() in sha1_file.c). Then the repository you borrow from _could_ change its own alternates after you set up your repository to borrow from it.

Currently, if the repository you borrowed from suddenly starts borrowing from somewhere else and pruned itself by running "repack -a -d -l", the borrower would be in trouble, even with your patch.