Re: [PATCH] fix some doc typos and grammar

From: Junio C Hamano <junkio@cox.net>
Date: Feb 2, 2007, 06:44 UTC
Message-ID: <7vmz3xjbxv.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <3c6c07c20702012225v19b7aa66vc98a028f700914db@mail.gmail.com>

"Mike Coleman" <tutufan@gmail.com> writes:

Show 5 quoted lines

> [This is my first patch, which I'm trying via cut-and-paste into
> gmail, which I realize sucks.  Any ideas for a better way?  Is anyone
> sending patches via gmail+pop?  I gave up my previous shell/email
> provider because they just weren't keeping the spam down.  Any
> suggestions for something that works?  --Mike]

It is usually nicer to put this "cover letter" material below the three dashes after Signed-off-by line; not a huge deal, though.

I was surprised that, for a patch that came from cut & paste via gmail, your patch did not have too many whitespace breakages. There was only one -- this hunk:

Show 5 quoted lines

> @@ -2923,6 +2923,8 @@ Think about how to create a clear chapter
> dependency graph that will
>  allow people to get to important topics without necessarily reading
>  everything in between.
>...

and after hand-fixing that overflowed hunk header, everything cleanly applied.

It might help if you did not say:

	Content-Type: text/plain; charset=ISO-8859-1; format=flowed

as "format=flawed" often seem to corrupt patches by wrapping lines. This might be fixable just by futzing with your MUA setting, or maybe gmail sets it and outside of your control; I do not know which, because I do not use gmail myself.

Show 9 quoted lines

> @@ -617,7 +617,7 @@ the relationships between these snapshots.
>  Git provides extremely flexible and fast tools for exploring the
>  history of a project.
>
> -We start with one specialized tool which is useful for finding the
> +We start with one specialized tool that is useful for finding the
>  commit that introduced a bug into a project.
>
>  How to use bisect to find a regression

Ah, "which or that", very funny. At work today I was working with somebody you know (AB) on a document, and he was fixing my that to which. Now you are fixing my which to that.

All the other hunks looked reasonable to me. Thanks, will apply, and I'll let others to fight over which and that ;-).