Re: [PATCH 0/9] Make gitexecdir relative to $(bindir) on Windows
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 23, 2008, 18:28 UTC
- Message-ID
- <7vmyk8e9p9.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <200807222131.32828.johannes.sixt@telecom.at>
Johannes Sixt <johannes.sixt@telecom.at> writes:
Show 18 quoted lines
> On Dienstag, 22. Juli 2008, Johannes Schindelin wrote: >> Hi, >> >> On Mon, 21 Jul 2008, Johannes Sixt wrote: >> > The problem was that argv[0] does not have a path in certain cases. >> >> Note that the same holds true for Linux when calling a program that is in >> the PATH: > > Oh, boy! > >> I imagine that the proper solution would be to rip out lookup_prog() and >> use it for non-Windows Git, too. Unless you want to limit the usefulness >> of your patch series to Windows, that is. > > This certainly goes beyond what I am prepared to do. It is not my itch. The > series is already much longer than I wanted, when there is a much simpler > solution that solves *my* problem: to set bindir = $(gitexecdir).
If you are living in the Windows world, perhaps you could record the installation location in resource somewhere from the installer and look it up at runtime? Or is it considered a bad practice?