Re: [RFC PATCH 0/4] Teach git fetch to verify signed tags automatically

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 24, 2008, 05:30 UTC
Message-ID: <7vmyfpn10v.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <7v4p1xohbw.fsf@gitster.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

Show 10 quoted lines

> Deskin Miller <deskinm@umich.edu> writes:
>
>> It struck me a while back when I fetched a new tagged release from git.git that
>> if I wanted to verify the tag's signature, I'd have to issue another command to
>> do so.  Shouldn't git be able to do that for me automatically, when it fetches
>> signed tags?  Now it does.  Also, 'git remote update' gets this for free.
>
> I think this should be done inside your own hook.  Not interested at all
> in a solution to touch builtin-fetch.c, unless if the patch is about
> adding a new hook so that people with other needs can use it as well.

... or a much stronger case can be made why this shouldn't be done in a hook.

I realize "not interested at all" was a bit too strong, so I am trying to rephrase it here. The cycle that begins with an RFC that leads to discussion and review is about clarifying the rationale and design incrementally, so please do not get offended by my no, and sorry for using unnecessarily strong wording.

What I meant was more like "The justification as given in the message does not interest me in the patch at all as it stands. I do not understand why this has to be done as a patch to git-fetch itself, not in a hook script, or why doing it inside git-fetch is a better approach than doing it in a hook (if there already is a hook mechanism to do this)".