Re: [PATCH v2] Make sure objects/pack exists before creating a new pack

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 26, 2009, 17:07 UTC
Message-ID: <7vmyc9t9d6.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <e2b179460902260754t38618c3fsf22a699ec35070cf@mail.gmail.com>

Mike Ralphson <mike.ralphson@gmail.com> writes:

Show 24 quoted lines

> 2009/2/26 Johannes Sixt <j.sixt@viscovery.net>:
>> Mike Ralphson schrieb:
>>> Even with j6t's patch, I'm seeing failures in t5300--pack-object.sh on AIX 5.3
>>>
>>> * FAIL 15: survive missing objects/pack directory
>>> fatal: Unable to create temporary file (): No such file or directory
>>
>> I can confirm this. Your patch is good. I wrapped it up:
>>
>> -- snip --
>> From: Mike Ralphson <mike.ralphson@gmail.com>
>> Subject: [PATCH] Fix odb_mkstemp() on AIX
>>
>> The AIX mkstemp() modifies its template parameter to an empty string if
>> the call fails.  The existing code had already recomputed the template,
>> but too late to be good.
>>
>> See also 6ff6af62, which fixed this problem in a different spot.
>
> Ah, I should have remembered that one.
>
> If my $DAYJOB email address could be used in the From, as per this s-o-b:
>
> Signed-off-by: Mike Ralphson <mike@abacus.co.uk>

Thanks.