git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] bisect: fix quoting TRIED revs when "bad" commit is also "skip"ped

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 27, 2009, 22:34 UTC
Message-ID
<7vmyc7ik5i.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<200902272205.10501.chriscool@tuxfamily.org>
Christian Couder <chriscool@tuxfamily.org> writes:
> So you should perhaps squash the following hunk to the patch:
> ...
> as this will string the commands together when there are no skipped commits 
> too.
Ok, good eyes.

Even though this part is directly from rev-list --bisect-vars and is much less likely to be malformed than the list of commands filter_skipped function produces, I agree it is a good discipline to protect it from the breakage the same way.

Thanks.
Previous: Christian Couder
Message 6 of 6 in “bisect: fix quoting TRIED revs when "bad" commit is also "skip"ped”
  1. bisect: fix quoting TRIED revs when "bad" commit is also "skip"pedChristian Couder, Feb 26, 2009
  2. Junio C HamanoFeb 26, 2009
  3. Christian CouderFeb 27, 2009
  4. Junio C HamanoFeb 27, 2009
  5. Christian CouderFeb 27, 2009
  6. Junio C HamanoFeb 27, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.