git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/3] t3400-rebase: Move detached HEAD check earlier

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 2, 2009, 08:03 UTC
Message-ID
<7vmyc45p2w.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<1235902803-32528-1-git-send-email-j6t@kdbg.org>
Johannes Sixt <j6t@kdbg.org> writes:
Show 6 quoted lines
> Long story: The test that preceded the one in question tests that a
> rebased commit degrades from a content change with mode change to a
> mere mode change.  But on Windows, where we have core.filemode=false,
> the original commit did not record the mode change, and so the rebase
> operation did not rebase anything.  This caused the subsequent detached
> HEAD test to fail.
Thanks.

I'll apply it as is since it is very close to the real release, but I think a more suitable fix would be to make tests less dependent on the outcome of earlier tests.

Previous: Johannes Sixt
Message 3 of 3 in “t3400-rebase: Move detached HEAD check earlier”
  1. 1/3 t3400-rebase: Move detached HEAD check earlierJohannes Sixt, Mar 1, 2009
  2. Johannes SixtMar 1, 2009
  3. Junio C HamanoMar 2, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.