Re: Tests in Cygwin

From: Junio C Hamano <gitster@pobox.com>
Date: May 8, 2009, 00:00 UTC
Message-ID: <7vmy9ocvlg.fsf@alter.siamese.dyndns.org>
In-Reply-To: <4A028A0A.5070003@viscovery.net>

Johannes Sixt <j.sixt@viscovery.net> writes:

Show 7 quoted lines

> You could squash in the patch below, where I chose to concatenate
> tokens with '+' because I dislike the extra quoting that is otherwise
> necessary at the call site. The downside is that it plays games with
> IFS, which you might find too ugly and not worth it. It's your call.
>
> BTW, I didn't dare test this as root on my production system; I'll do
> that later today elsewhere.

Heh, thanks.

I think my "how about this" weather-balloon patch with your updates should be split into a three-patch series:

 (1) t/README update to cover the Prerequisite system; we should have done
     this when we applied the feature;

 (2) Addition of multiple-prerequisite feature (and documentation updates
     to t/README);

 (3) Addition of SANITY prerequisite that uses (2).

I personally do not think "SANITY" is such a good thing to look for (I'd rather make the test fail saying "do not run me as root"), but that is a separate issue.