Re: [PATCHv2 3/4] git-am foreign patch support: StGIT support

From: Junio C Hamano <gitster@pobox.com>
Date: May 27, 2009, 20:50 UTC
Message-ID: <7vmy8yi82s.fsf@alter.siamese.dyndns.org>
In-Reply-To: <cb7bb73a0905270129j375ac104yb9ca8601312ddbde@mail.gmail.com>

Giuseppe Bilotta <giuseppe.bilotta@gmail.com> writes:

Show 12 quoted lines

> On Wed, May 27, 2009 at 9:19 AM, Junio C Hamano <gitster@pobox.com> wrote:
>> Giuseppe Bilotta <giuseppe.bilotta@gmail.com> writes:
>>
>>> +             # set the patch format appropriately
>>> +             patch_format=stgit
>>> +             # now handle the actual StGIT patches
>>> +             split_patches "$@"
>>
>> Can an stgit patch file (or the leading pathname for that matter) have IFS
>> character in its name?
>
> StGIT sanitizes filenames in a way similar to what format-patch does.

Good ;-)

Show 5 quoted lines

>> Since we rely on Perl but not awk in core-ish part of the scripted
>> Porcelains, it might be a good idea to write this in Perl as well.
>
> By 'as well' you mean in case awk is missing, and have both, or by
> only keeping a perl version?

"As well" I meant "Using Perl instead of awk, just like other scripted Porcelains."