Re: [PATCH 3/5] make "git unpack-file" a built-in
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 22, 2010, 18:04 UTC
- Message-ID
- <7vmy06vwvy.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <alpine.LFD.2.00.1001220826230.13231@localhost.localdomain>
Linus Torvalds <torvalds@linux-foundation.org> writes:
Show 31 quoted lines
> From: Linus Torvalds <torvalds@linux-foundation.org>
> Date: Fri, 22 Jan 2010 07:38:03 -0800
>
> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
> ---
> Again.. No surprises.
> ...
> diff --git a/unpack-file.c b/builtin-unpack-file.c
> similarity index 89%
> rename from unpack-file.c
> rename to builtin-unpack-file.c
> index e9d8934..608590a 100644
> --- a/unpack-file.c
> +++ b/builtin-unpack-file.c
> @@ -22,18 +22,15 @@ static char *create_temp_file(unsigned char *sha1)
> return path;
> }
>
> -int main(int argc, char **argv)
> +int cmd_unpack_file(int argc, const char **argv, const char *prefix)
> {
> unsigned char sha1[20];
>
> - git_extract_argv0_path(argv[0]);
> -
> if (argc != 2 || !strcmp(argv[1], "-h"))
> usage("git unpack-file <sha1>");
> if (get_sha1(argv[1], sha1))
> die("Not a valid object name %s", argv[1]);
>
> - setup_git_directory();This will now require "git unpack-file -h" to be run in a git controlled directory, so strictly speaking it changes behaviour.
Not that anybody would care that much, though.