git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] t9010 fails when no svn is available

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 9, 2010, 06:53 UTC
Message-ID
<7vmxofh1x4.fsf@alter.siamese.dyndns.org>
Running test t9010 without svn currently errors out for no good reason.

The test uses "svnadmin" without checking if svn is available. This was a regression introduced by b0ad24b (t9010 (svn-fe): Eliminate dependency on svn perl bindings, 2010-10-10) when it stopped including ./lib-git-svn.sh that had the safety.

This should fix it.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 t/t9010-svn-fe.sh |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/t/t9010-svn-fe.sh b/t/t9010-svn-fe.sh
index fd851a4..faf9092 100755
--- a/t/t9010-svn-fe.sh
+++ b/t/t9010-svn-fe.sh
@@ -4,6 +4,12 @@ test_description='check svn dumpfile importer'
 
 . ./test-lib.sh
 
+if ! svnadmin -h >/dev/null 2>&1
+then
+	skip_all='skipping svn-fe tests, svn not available'
+	test_done
+fi
+
 svnconf=$PWD/svnconf
 export svnconf
 
Next: Ramkumar Ramachandra
Message 1 of 2 in “t9010 fails when no svn is available”
  1. t9010 fails when no svn is availableJunio C Hamano, Dec 9, 2010
  2. Ramkumar RamachandraDec 9, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.