Re: [PATCH 1/2] diff/status: refactor opportunistic index update

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 21, 2011, 19:39 UTC
Message-ID: <7vmxkop8js.fsf@alter.siamese.dyndns.org>
In-Reply-To: <AANLkTinUqzgpiX_X+kpUuOSxNqRVp+OC1HOreEkF6yhX@mail.gmail.com>

Piotr Krukowiecki <piotr.krukowiecki@gmail.com> writes:

Show 10 quoted lines

> On Mon, Mar 21, 2011 at 6:16 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> +void update_index_if_able(struct index_state *istate, struct lock_file *lockfile)
>> +{
>> +       if (istate->cache_changed) &&
>> +           !write_index(istate, lockfile->fd))
>
> Mismatched parenthesis? Should be sth like
>
> +       if (istate->cache_changed &&
> +           !write_index(istate, lockfile->fd))

Yeah, "rebase -i" gotcha.  Applying [2/2] should get rid of it anyway.