Re: [fyi] patches used by git distributors

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 8, 2011, 20:41 UTC
Message-ID: <7vmxc6xs73.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20111108090251.GB17954@elie.hsd1.il.comcast.net>

Jonathan Nieder <jrnieder@gmail.com> writes:

Note that I didn't check any of the patches that are not linked in references section.

Show 5 quoted lines

> Gerrit Pape (1):
>       bug#506445: hooks/post-receive-email: set encoding to utf-8 [2]
>
> Jonathan Nieder (12):
>       remove shebang line from shell libraries [3]

If this is about git-sh-setup, I think it is probably a good idea to upstream it.

>       pre-rebase hook: capture documentation in a <<here document [4]

I do not mind this but if you are to do so you should remove the "exit 0" before that block.

Show 8 quoted lines

>       transport: expose git_tcp_connect and friends in new tcp.h [5]
>       daemon: make host resolution into a separate function [5]
>       daemon: move locate_host to tcp.c [5]
>       tcp: unify ipv4 and ipv6 code paths [5]
>       daemon: check for errors retrieving IP address [5]
>       tcp: make dns_resolve return an error code [5]
>       transport: optionally honor DNS SRV records [5]
>       srv: make errors less quiet [5]

It seems that this received almost no interest from anybody. I suspect that the reason was because the cover letter was poorly written that people did not realize the need for it.

>       Makefile: add a knob to turn off hardlinks within same directory [6]

I think the real fix for this issue should be either made in btrfs or even better "tar x", instead of forcing everybody who consumes a tarball to use symlink or copies. That is, work-around should be made when a _particular_ recipient wants to extract a tarball that stores hardlinks to the same inode than the filesystem the recipient _happens_ to be trying to extract it on, not before.