Re: [PATCH v5 1/5] http: try http_proxy env var when http.proxy config option is not set

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 14, 2012, 23:27 UTC
Message-ID: <7vmx6d28t2.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20120413205222.GB7919@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 14 quoted lines

> On Fri, Apr 13, 2012 at 04:48:58PM -0400, Jeff King wrote:
>
>> > +	if (!curl_http_proxy) {
>> > +		const char *env_proxy, *no_proxy;
>> > +		char *env_proxy_var;
>> > +		int read_http_proxy;
>> > +		struct strbuf buf = STRBUF_INIT;
>> > +		credential_from_url(&cre_url, url);
>> > +		strbuf_addf(&buf, "%s_proxy", cre_url.protocol);
>> > +		env_proxy_var = strbuf_detach(&buf, NULL);
>> > +		env_proxy = getenv(env_proxy_var);
>
> Also, shouldn't we be checking HTTPS_PROXY in addition to https_proxy,
> by curl's rules? Only http_proxy is not allowed to be upper-cased.

Good point.