Re: [PATCH 1/2] git-p4: Test changelists touching two branches

From: Junio C Hamano <gitster@pobox.com>
Date: May 25, 2012, 00:02 UTC
Message-ID: <7vmx4xunzr.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CAOpHH-U+cG2DvTtWD25JNgLYKrNcwXgqysA0G-wr5DFhLG-DAg@mail.gmail.com>

Vitor Antunes <vitor.hda@gmail.com> writes:

Show 12 quoted lines

> What about the parentheses in the next line, is it necessary? Or can I
> simply remove that pair of parentheses and unindent the code in
> between?
>
>> ...
>>> +     (
>>> +             cd "$cli" &&
>>> +             p4 integrate //depot/branch3/file3 //depot/branch4/file3 &&
>>> +             p4 delete //depot/branch3/file3 &&
>>> +             p4 submit -d "Move branch3/file3 to branch4/file3"
>>> +     )
>>> +'

If you mean this part, the parentheses to throw you into a subprocess are required. Otherwise, a failure in any of these three p4 commands will leave you in $cli directory, causing the next test to start in a directory that it does not expect.