Re: Bug: git ls-files and ignored directories

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 4, 2012, 02:12 UTC
Message-ID: <7vmx4jvn8j.fsf@alter.siamese.dyndns.org>
In-Reply-To: <7vwr3ovxsp.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

Show 15 quoted lines

> As we are already in "regression fix only" phase, it won't be in the
> upcoming 1.7.11 series, even though it may deserve to be in 1.7.11.2
> maintenance release.
>
> I see other uses of excluded() in builtin/add.c and unpack-trees.c;
> these call sites need to be audited.
>
> If they have the same problem, it probably is a good idea to convert
> them to use path_excluded(), move the path_excluded() function and
> its supporting infrastructure from builtin/ls-files.c to dir.c, and
> make excluded() a file-static function to dir.c in order to avoid
> similar problems in the future.  Or their use may be alright.
>
> The work described in the previous paragraph preferrably should
> happen before the change is shipped as part of any release.

I've moved the path_excluded() stuff to dir.[ch] and queued the result to 'pu', but didn't look at other uses of excluded().

Just in case somebody is interested in working on it further.