Re: [PATCH v8 4/5] Implement line-history search (git log -L)

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 28, 2013, 22:23 UTC
Message-ID: <7vmwuogjsm.fsf@alter.siamese.dyndns.org>
In-Reply-To: <7vbob4iaxh.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

Show 7 quoted lines

> Overall, I like this better than the "log --follow" hack; as the
> revision traversal is done without any pathspec when being "careful
> and slow" (aka -M), you do not suffer from the "just use a singleton
> pathspec globally regardless of what other history paths are being
> traversed" limitation of "log --follow".
>
> The patch series certainly is interesting.

Having said that, I notice that "careful and slow" is just "too slow to be usable" even on a small tree like ours. Try running

    $ git log -M -L:get_name:builtin/describe.c

and see how long you have to wait until you hit the first line of output.

If some of the many NEEDSWORK in the code were fixed, this may become "very slow but tolerable", but in the current shape, I doubt it would be prudent to advance this to 'next' and further.