Re: [PATCH v2 2/3] environment: add GIT_PREFIX to local_repo_env

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 8, 2013, 23:03 UTC
Message-ID: <7vmwudfq9r.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20130308214404.GA9723@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 15 quoted lines

> On Fri, Mar 08, 2013 at 04:39:02PM -0500, Eric Sunshine wrote:
>
>> On Fri, Mar 8, 2013 at 4:30 AM, Jeff King <peff@peff.net> wrote:
>> > The GIT_PREFIX variable is set based on our location within
>> > the working tree. It should therefore be cleared whenever
>> > GIT_WORK_TREE is cleared.
>> >
>> > In practice, this doesn't cause any bugs, because none of
>> > the sub-programs we invoke with local_repo_env cleared
>> > actually care about GIT_PREFIX. But this is the right thing
>> > to do, and future proofs us again that assumption changing.
>> 
>> s/again/against/
>
> Yep, thanks.

Thanks; squashed-in.