Re: [PATCH] git pull cannot find remote refs.

From: Junio C Hamano <junkio@cox.net>
Date: Feb 28, 2006, 01:13 UTC
Message-ID: <7vlkvwuvyl.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20060227214936.GA7205@scotty.home>

"Stefan-W. Hahn" <stefan.hahn@s-hahn.de> writes:

Show 6 quoted lines

> Tracking it down, I found a gap between how git-ls-remote prints out the tags
> and git-fetch scans them with sed. Looking at the code of git-ls-remote the
> there is an tab character between the sha1 and the refname, while there is a
> space and a tab character in the regular expression for th sed command.
>
> As a result the while where all is piped in cannot read the two values.

Sorry.

I do not understand the above comment, nor the following code.

>  		git-ls-remote $upload_pack --tags "$remote" |
> -		sed -ne 's|^\([0-9a-f]*\)[ 	]\(refs/tags/.*\)^{}$|\1 \2|p' |
> +		sed -ne 's|^\([0-9a-f]*\)[\t]\(refs/tags/.*\)^{}$|\1 \2|p' |

ls-remote shows "SHA1\tPATH". The original says "hexadecimal followed by [either a single space or a single tab] followed by a refpath", while yours says "hexadecimal followed by a single tab followed by a refpath". I do not see how that would make any difference. Puzzled...

I've seen two servers DNS round-robin and one of them fail to respond. The first "fetch" goes to the good one and the second ls-remote goes to the bad one, then you would see "Oops, we cannot peek tags". But this patch does not have anything to do with that problem..