Re: [PATCH] Make cvsexportcommit work with filenames with spaces and non-ascii characters.

From: Junio C Hamano <junkio@cox.net>
Date: Dec 10, 2006, 21:27 UTC
Message-ID: <7vlklf4f1s.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <200612101639.22397.robin.rosenberg@dewire.com>

Robin Rosenberg <robin.rosenberg@dewire.com> writes:

Show 6 quoted lines

>> Well, have you tried this?
>>
>> 	git diff-tree -p --binary fe142b3a | git apply --summary --numstat
> of course not. I didn't understand it. Why can't it tell me about removed
> binary files, so I could remove the git-diff-tree invocation to find out about 
> added/removed files?

Maybe I am missing something. It tells you about added or removed files (either binary or non-binary).

I'd prepare a pair of practice patch files. "forward" has creation, "reverse" has addition.

$ git diff-tree -p --binary fe142b3a >forward.patch $ git diff-tree -R -p --binary fe142b3a >reverse.patch

$ git apply --summary --numstat forward.patch
50      20      git-cvsexportcommit.perl
145     0       t/t9200-git-cvsexportcommit.sh
-       -       t/test9200a.png
-       -       t/test9200b.png
 create mode 100755 t/t9200-git-cvsexportcommit.sh
 create mode 100644 t/test9200a.png
 create mode 100644 t/test9200b.png

$ git apply --summary --numstat reverse.patch
20      50      git-cvsexportcommit.perl
0       145     t/t9200-git-cvsexportcommit.sh
-       -       t/test9200a.png
-       -       t/test9200b.png
 delete mode 100755 t/t9200-git-cvsexportcommit.sh
 delete mode 100644 t/test9200a.png
 delete mode 100644 t/test9200b.png

> This fuzz gives some, but not much slack. Reverting the option could be a 
> good idea.
>
> Update follows.

Ok.