git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/17] Sliding window mmap for packfiles.

From
Junio C Hamano <junkio@cox.net>
Date
Dec 23, 2006, 09:37 UTC
Message-ID
<7vlkkzrm0w.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<20061223073317.GA9837@spearce.org>

I have to say i am very much impressed (I've taken a look at only the first half up to #11, though). How much has this been used in real projects?

A couple of comments:
[3/17]

I think losing "p->next = NULL" does not matter with the callers we have right now, but somehow this part makes me feel uneasy.

[5/17]

I think it makes sense to exit(0) for the existing write_or_die upon EPIPE because that indicates we are the upstream of the pipe and the reading process has exit (i.e. user said 'q' to less while we still have more to say).

I suspect the symmetry would not hold for read_or_die; when we are reading, EPIPE is not any different from any other errors (except for EAGAIN or EINTR which we already take care of in xread()) and the net effect is that we could not read what we wanted to.

Previous: Shawn O. PearceNext: Shawn Pearce
Message 2 of 9 in “Sliding window mmap for packfiles.”
  1. 0/17 Sliding window mmap for packfiles.Shawn O. Pearce, Dec 23, 2006
  2. Junio C HamanoDec 23, 2006
  3. Shawn PearceDec 23, 2006
  4. Francis MoreauDec 24, 2006
  5. Shawn PearceDec 24, 2006
  6. Francis MoreauDec 24, 2006
  7. Shawn PearceDec 24, 2006
  8. Andy WhitcroftJan 2, 2007
  9. Linus TorvaldsDec 24, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.