[PATCH] diff.c: truly honor size_only request for populate_filespec.

From: Junio C Hamano <junkio@cox.net>
Date: May 6, 2007, 08:49 UTC
Message-ID: <7vlkg2cp5h.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <7vr6pucp9e.fsf@assigned-by-dhcp.cox.net>

For some reason we did not honor size_only requests when "size cache" was in use. They should be independent.

Signed-off-by: Junio C Hamano <junkio@cox.net>
---

 * I think this is a right fix.  When used together with other
   patches, it seems to help reducing the memory footprint a
   bit, but by itself not that much and it seems to have
   slightly negative performance impact.

 diff.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/diff.c b/diff.c
index 7bbe759..02c9467 100644
--- a/diff.c
+++ b/diff.c
@@ -1503,9 +1503,6 @@ int diff_populate_filespec(struct diff_filespec *s, int size_only)
 	if (S_ISDIR(s->mode))
 		return -1;
 
-	if (!use_size_cache)
-		size_only = 0;
-
 	if (s->data)
 		return err;

-- 
1.5.2.rc1.697.g5086