Re: [PATCH] the use of 'tr' in the test suite isn't really portable

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 17, 2007, 20:25 UTC
Message-ID: <7vlk7t6pc6.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20071217191508.79cc05e2@pc09.procura.nl>

The contents looked correct but the patch was garbled.

--

Applying the use of 'tr' in the test suite isn't really portable
.dotest/patch:11: indent with spaces.
               git diff-index -r $commit | cut -f 2- | tr '\n' '\000' | \
.dotest/patch:153: indent with spaces.
            dd if=/dev/zero bs=4k count=1 | tr "\\000" $i >$i &&
.dotest/patch:165: indent with spaces.
                       tr '\000' 'g'
.dotest/patch:174: indent with spaces.
                       tr '\000' 'g'
error: patch failed: git-filter-branch.sh:290
error: git-filter-branch.sh: patch does not apply
error: patch failed: t/t0020-crlf.sh:5
error: t/t0020-crlf.sh: patch does not apply
error: patch failed: t/t3300-funny-names.sh:54
error: t/t3300-funny-names.sh: patch does not apply
error: patch failed: t/t4020-diff-external.sh:99
error: t/t4020-diff-external.sh: patch does not apply
error: patch failed: t/t4116-apply-reverse.sh:12
error: t/t4116-apply-reverse.sh: patch does not apply
error: patch failed: t/t4200-rerere.sh:129
error: t/t4200-rerere.sh: patch does not apply
error: patch failed: t/t5300-pack-object.sh:15
error: t/t5300-pack-object.sh: patch does not apply
error: patch failed: test-sha1.sh:10
error: test-sha1.sh: patch does not apply
.dotest/patch:11: indent with spaces.
               git diff-index -r $commit | cut -f 2- | tr '\n' '\000' | \
.dotest/patch:153: indent with spaces.
            dd if=/dev/zero bs=4k count=1 | tr "\\000" $i >$i &&
.dotest/patch:165: indent with spaces.
                       tr '\000' 'g'
.dotest/patch:174: indent with spaces.
                       tr '\000' 'g'