git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Work around curl-gnutls not liking to be reinitialized

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 8, 2008, 21:46 UTC
Message-ID
<7vlk5vi0k9.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<20080208213148.GA2823@glandium.org>
Mike Hommey <mh@glandium.org> writes:
Show 11 quoted lines
>>  In the end, it was a bit of git's fault, but either curl or gnutls is the
>>  actual culprit. I've not looked into either code to find out who's
>>  responsible, but a very simplified testcase is as follows:
>> ...
>
> And the winner is... curl !
> The bug was introduced in this commit:
> http://cool.haxx.se/cvs.cgi/curl/lib/gtls.c.diff?r1=1.26&r2=1.27
> Note how gtls_inited is not set back to FALSE in cleanup.
>
> This ended up released in 7.16.3. I'm filing a bug.
Good detetive work.  Thanks.

I guess we need to ship with a known leak to work this around. Sigh...

Perhaps we can convince cURL developers to switch to git while we are at it? ;-)

Previous: Mike HommeyNext: Mike Hommey
Message 17 of 44 in “git-fetch in 1.5.4 fails versus 1.5.3.8”
  1. Anand KumriaFeb 4, 2008
  2. Jeff KingFeb 5, 2008
  3. Jari AaltoFeb 5, 2008
  4. Anand KumriaFeb 6, 2008
  5. Jeff KingFeb 7, 2008
  6. Mike HommeyFeb 7, 2008
  7. Anand KumriaFeb 7, 2008
  8. Jeff KingFeb 7, 2008
  9. Mike HommeyFeb 7, 2008
  10. Jeff KingFeb 7, 2008
  11. Mike HommeyFeb 7, 2008
  12. Jeff KingFeb 8, 2008
  13. Mike HommeyFeb 8, 2008
  14. Mike HommeyFeb 8, 2008
  15. Work around curl-gnutls not liking to be reinitializedMike Hommey, Feb 8, 2008
  16. Mike HommeyFeb 8, 2008
  17. Junio C HamanoFeb 8, 2008
  18. Mike HommeyFeb 8, 2008
  19. Mike HommeyFeb 8, 2008
  20. Work around curl-gnutls not liking to be reinitializedMike Hommey, Feb 8, 2008
  21. Johannes SchindelinFeb 8, 2008
  22. Work around curl-gnutls not liking to be reinitializedMike Hommey, Feb 8, 2008
  23. Mike HommeyFeb 8, 2008
  24. Work around curl-gnutls not liking to be reinitializedMike Hommey, Feb 9, 2008
  25. Daniel StenbergFeb 9, 2008
  26. Florian WeimerFeb 9, 2008
  27. Mike HommeyFeb 9, 2008
  28. Johannes SchindelinFeb 8, 2008
  29. Mike HommeyFeb 8, 2008
  30. Jeff KingFeb 9, 2008
  31. Frank LichtenheldFeb 7, 2008
  32. Linus TorvaldsFeb 7, 2008
  33. Frank LichtenheldFeb 7, 2008
  34. Linus TorvaldsFeb 7, 2008
  35. Anand KumriaFeb 7, 2008
  36. Jeff KingFeb 7, 2008
  37. Linus TorvaldsFeb 7, 2008
  38. Martin LanghoffFeb 7, 2008
  39. Dmitry PotapovFeb 7, 2008
  40. Jeff KingFeb 7, 2008
  41. Jeff KingFeb 7, 2008
  42. Dmitry PotapovFeb 7, 2008
  43. Anand KumriaFeb 8, 2008
  44. Dmitry PotapovFeb 8, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.