git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t7501: always use test_cmp instead of diff

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 10, 2008, 00:02 UTC
Message-ID
<7vljy03m2m.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<20080909235414.GA4768@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 18 quoted lines
> On Wed, Sep 10, 2008 at 01:41:06AM +0200, Miklos Vajna wrote:
>
>>  test_expect_success \
>>      'validate git-rev-list output.' \
>> -    'diff current expected'
>> +    'test_cmp current expected'
>
> We seem to use the convention of
>
>   test_cmp <expected> <actual>
>
> elsewhere, rather than
>
>   test_cmp <actual> <expected>
>
> as you have here.  Most noticeably, that means the diff will show
> deviations from expected, rather "what should be done to make this as
> expected".

Yes, please. I am glad to see somebody noticed it (I've been fixing these whenever I touched vicinity of the ones that had comparisons swapped).

Previous: Jeff KingNext: Miklos Vajna
Message 4 of 5 in “t7501: always use test_cmp instead of diff”
  1. t7501: always use test_cmp instead of diffMiklos Vajna, Sep 9, 2008
  2. Miklos VajnaSep 9, 2008
  3. Jeff KingSep 9, 2008
  4. Junio C HamanoSep 10, 2008
  5. t7501: always use test_cmp instead of diffMiklos Vajna, Sep 10, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.