git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] Clarify the gitmodules and submodules docs

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 8, 2009, 07:16 UTC
Message-ID
<7vljqbpqdh.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<526944450904080004r1249d1b8j4a44472d72502b9c@mail.gmail.com>

I think the new description is good, and the message claims to be sent by send-email, but I am seeing a funny whitespace damage everywhere in your patch.

 * Signed-off-by: and the three-dash lines have a leading SP
 * The first line of diffstat is indented by one SP as expected; the
   second line has one extra SP at the beginning.
 * everything after that has one extra SP at the beginning.  Also the hunk
   header for the first hunk is linewrapped.

Very curious. I could just hand munge the patch if I wanted to, but I'd rather not. As you are in "GSoC preparation", I expect to receive patches, perhaps tons of them, from you in the future, and I'd want to see easier procedural wrinkles straightened out first. That will allow us to concentrate on the substance when "the real thing" starts.

    Added some explanation to the docs to clear up some confusing parts of
    git-submodules that appeared frequently on the mailing list.

We tend to say "Add some explanation..." here. Think of it as your giving an order to _me_, "cause this to happen", by accepting and applying your patch.

Previous: P Baker
Message 2 of 2 in “Clarify the gitmodules and submodules docs”
  1. 1/2 Clarify the gitmodules and submodules docsP Baker, Apr 8, 2009
  2. Junio C HamanoApr 8, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.