git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC 1/8] UTF helpers

From
Junio C Hamano <gitster@pobox.com>
Date
May 13, 2009, 18:48 UTC
Message-ID
<7vljp04z6j.fsf@alter.siamese.dyndns.org>
In-Reply-To
<4A0A91CE.3080905@gmail.com>
Esko Luontola <esko.luontola@gmail.com> writes:
Show 10 quoted lines
> Robin Rosenberg wrote on 13.5.2009 8:24:
>> If the conclusion is that this is a way forward, then I
>> could start working on a completely new set of much cleaner patches.,
>
> That would be great!
>
> I see that in those early patches you took the approach of converting
> the filenames from the local encoding to UTF-8 at the outer edges of
> Git. That obviously was the easiest way to make the changes with
> minimal changes to Git.
Which would be the _only_ sane approach.

If you allow people to record otherwise exactly the same tree object in different encoding, like you seem to have in mind, subtree comparision based on the object name will not work and you will end up always traversing down to the tip, because you won't know if your subtrees need filename iconv until you recurse into them and actually take a look.

Don't do it.
Previous: Alex RiesenNext: Esko Luontola
Message 12 of 20 in “[RFC 0/8] Antique UTF-8 filename support”
  1. Robin RosenbergMay 12, 2009
  2. 1/8 UTF helpersRobin Rosenberg, May 12, 2009
  3. 2/8 Messages in locale.Robin Rosenberg, May 12, 2009
  4. 3/8 Extend tests to cover locale wrt to commit messages.Robin Rosenberg, May 12, 2009
  5. 4/8 UTF file names.Robin Rosenberg, May 12, 2009
  6. Johannes SchindelinMay 13, 2009
  7. Robin RosenbergMay 13, 2009
  8. Esko LuontolaMay 13, 2009
  9. Andreas EricssonMay 13, 2009
  10. Esko LuontolaMay 13, 2009
  11. Alex RiesenMay 13, 2009
  12. Junio C HamanoMay 13, 2009
  13. Esko LuontolaMay 13, 2009
  14. Junio C HamanoMay 13, 2009
  15. Johannes SchindelinMay 13, 2009
  16. Junio C HamanoMay 14, 2009
  17. Jay SoffianMay 14, 2009
  18. 6/8 test of utf_locallinksRobin Rosenberg, May 12, 2009
  19. 7/8 Convert symlink dest in diffRobin Rosenberg, May 12, 2009
  20. 8/8 UTF-8 in non-SHA1-objectsRobin Rosenberg, May 12, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.